Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default resources mutated when applying templates #1948

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: default resources mutated when applying templates #1948

merged 1 commit into from
Aug 15, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 15, 2024

Fixes: #1906

@whynowy whynowy requested a review from vigith as a code owner August 15, 2024 17:35
@whynowy whynowy requested a review from kohlisid August 15, 2024 17:35
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.81%. Comparing base (9e96386) to head (9c4abf6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   57.44%   57.81%   +0.36%     
==========================================
  Files         412      412              
  Lines       28789    28789              
==========================================
+ Hits        16537    16643     +106     
+ Misses      11307    11206     -101     
+ Partials      945      940       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kohlisid
kohlisid approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@kohlisid kohlisid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whynowy Could there be other fields which might get affected due to similar behavior?

@whynowy
Copy link
Member Author

whynowy commented Aug 15, 2024 •
edited
Loading

@whynowy Could there be other fields which might get affected due to similar behavior?

The req.resources should be the only one.

@whynowy whynowy merged commit c4b5d05 into numaproj:main Aug 15, 2024
25 checks passed
@whynowy whynowy deleted the cf branch August 15, 2024 18:27
KeranYang pushed a commit that referenced this pull request Aug 19, 2024
@whynowy @KeranYang
fix: default resources mutated when applying templates (#1948)
447cd3f 
Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohlisid kohlisid kohlisid approved these changes

@vigith vigith vigith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

containerTemplate gets propagated to initContainer in spec
3 participants
@whynowy @vigith @kohlisid